Repository navigation
[dv] Include CHERIoT Load/Store/Jump signals in fcov assertions - #2506
Merged
Merged
Conversation
Signed-off-by: Samuel Riedel <sriedel@lowrisc.org>
Contributor
|
Just to check, does |
Contributor
|
Actually, looking back at my original notes I can't see |
elliotb-lowrisc
approved these changes
Sep 18, 2026
elliotb-lowrisc
left a comment
elliotb-lowrisc
left a comment
Contributor
There was a problem hiding this comment.
All three assertions changed here go from firing to not firing in my testing, so all good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those fcov assertions were not properly updated when adding CHERIoT. Because those CHERIoT instructions are decoded with different control signals, we have to look out for both.